Fix KeyError

[mzfr]

Fixes #201

There was no hash key in the /status_404. Instead, that key is present in /index.html

{'/index.html': {'hash': 'd1546d731a9f30cc80127d57142a482b', 'content_type': 'text/html'}, '/status_404': {}}

So I fixed that and now snare starts properly.

[adepasquale]

SnareMiddleware constructor requires the 1st param to be the filename of the HTTP 404 page, so that's not meant to be changed.

[mzfr]

okay so how do you suggest we tackle that issue?
As we can see in value of self.meta I posted above the /status_404 key has no values in the dictionary.

Should we add just put that code between a try & catch block?

[adepasquale]

What clone command did you run in order to generate a meta.json without that /status_404 key?

[mzfr]

I used sudo clone --target example.com

[mzfr]

so I tested it again with the same command sudo clone --target example.com and now there was hash key in the status_404. So not really sure why this might be happening.

But still the good practice would be to just put this statement in a try & except block.

we can do something like:

try:
	  middleware = SnareMiddleware(
           self.meta['/status_404']['hash'],
           self.run_args.server_header
        )
except KeyError:
	print_color("No hash value found for 404 page", ERROR)
	print_color("Please try to clone the page/website again", INFO) 

@afeena @adepasquale what are your thoughts about it?

[afeena]

@mzfr I think it would be better to make a validation function to make sure that provided page has needed meta info

[mzfr]

Ok then I'll implement validation function ASAP

[afeena]

Since suggested changes made in #251, closed