-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add base shortcuts #517
base: main
Are you sure you want to change the base?
Add base shortcuts #517
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see in-line feedback - keep the PR small and simple and focus only on the media controls. Also, you are only accounting for the happy flow now. If the api connection is not there yet or no player is active this will crash
a8f5641
to
0cb842a
Compare
4194a66
to
8260bf9
Compare
I've just tested this PR and it was not working, especially not in the subpages. |
This is part of the request #1645 , it adds shortcuts to the UI
Adding the media control for:
Mute
Volume Up/Down
Play/Pause
Stop
Prev/Next track
Unfortunately you need to have the window focus to make it work since mediaSession doesnt seems to work with my integration