Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A couple adjustments to prevent flickering on Drop style ... #5

Merged
merged 3 commits into from
Oct 3, 2013

Commits on Sep 29, 2013

  1. A couple adjustments to the dismiss to prevent flickering on Drop sty…

    …le when dismiss is called too soon
    Hari Karam Singh committed Sep 29, 2013
    Configuration menu
    Copy the full SHA
    4ecdc8e View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2013

  1. Configuration menu
    Copy the full SHA
    7c5c605 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2013

  1. BG animaton happens on new showAnimationCompletion block. Fixe for co…

    …mpletion blocks not being nil'ed.
    
    Still doesnt solve problem which is: On my iPhone4 device (not simulator) if the drop animation is dismissed before finished showing (and therefore queued), the hud pops back to the center before being removed by the completion block.  I've tried:
    
    - disabling the CATransaction begin/end when it's queue (as the queue block is contained in the showAnimation's transaction)
    - setting removedOnCompletion to NO in _dropAnimationOut
    - hud.layer.removeAllAnimations before adding the dismiss animations
    - breaking in the dismiss completion block.  The hud is already been moved back to centre so it's not the cleanupAfter method or anything happening in completion.
    - Subtracting 0.15 from the BG fade animation duration (which == *Long for drop animation) which is the only thing that works but is a total hack and very timing sensitive.  I've commented this out in the committed code.
    
    Would love to fix this but I need to move on with my project.  Can't figure out why this would only happen when queued.  Must be the showAnimation taking precedent somehow...
    
    Side note: For the completion block(s), I've added code to nil them after they are called as was specified in the comments for dismissAnimationCompletion.
    Hari Karam Singh committed Oct 3, 2013
    Configuration menu
    Copy the full SHA
    b3e434f View commit details
    Browse the repository at this point in the history