Adding new options to record population steps #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @param dictionary The dictionary being used to populate the given record. | ||
| @return id The primary key to associate with the record. | ||
| */ | ||
| typedef id (^MMRecordOptionsEntityPrimaryKeyInjectionBlock)(NSEntityDescription *entity, |
There was a problem hiding this comment.
Are there any restrictions on what this primary keyed object should be? I'm betting it should at least be NSCopying compliant, no?
There was a problem hiding this comment.
Yeah thats definitely true. Do you think thats worth adding? That would also make it more clear that this is NOT for use with record to parent record primary keys, since NSManagedObjects don't support NSCopying.
There was a problem hiding this comment.
I always prefer compile-time errors and warnings over exceptions and assertions.
|
Merged into the 1.3.0 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some speculative work on adding a few new customization options to the record population workflow for supporting:
Feedback is very welcome