Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update React peer dependencies to include RCs #1005

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

heff
Copy link
Contributor

@heff heff commented Oct 23, 2024

Might be overkill and I have not tested this. It was throwing this error on a fresh next.js project with react at an RC version.
image

@heff heff requested a review from a team as a code owner October 23, 2024 22:22
Copy link

vercel bot commented Oct 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
elements-demo-create-react-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 10:27pm
elements-demo-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 10:27pm
elements-demo-svelte-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 10:27pm
elements-demo-vanilla ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 10:27pm
elements-demo-vue ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 10:27pm

Copy link
Contributor

@luwes luwes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

https://semver.npmjs.com/
I think it works but it only lists the prereleases in the test page if you use the ^19 || ^19.0.0-0 separately. not sure why

@luwes luwes merged commit 2775da4 into main Oct 24, 2024
14 checks passed
@luwes luwes deleted the react-peer-dependencies branch October 24, 2024 17:22
luwes added a commit that referenced this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants