Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add rendition unavailable / unsupported #715

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

luwes
Copy link
Contributor

@luwes luwes commented Aug 10, 2023

No description provided.

@luwes luwes self-assigned this Aug 10, 2023
@luwes luwes requested review from heff and a team as code owners August 10, 2023 00:28
@vercel
Copy link

vercel bot commented Aug 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
media-chrome ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 10, 2023 0:28am
media-chrome-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 10, 2023 0:28am

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #715 (8a4a3e6) into main (8a003bf) will increase coverage by 0.04%.
Report is 2 commits behind head on main.
The diff coverage is 86.11%.

@@            Coverage Diff             @@
##             main     #715      +/-   ##
==========================================
+ Coverage   72.93%   72.97%   +0.04%     
==========================================
  Files          53       53              
  Lines        9842     9877      +35     
==========================================
+ Hits         7178     7208      +30     
- Misses       2664     2669       +5     
Files Changed Coverage Δ
src/js/controller.js 63.41% <75.00%> (+0.24%) ⬆️
src/js/constants.js 100.00% <100.00%> (ø)
src/js/experimental/media-rendition-button.js 88.46% <100.00%> (+0.46%) ⬆️
src/js/experimental/media-rendition-selectmenu.js 65.30% <100.00%> (+11.25%) ⬆️
src/js/media-theme-element.js 91.79% <100.00%> (+0.03%) ⬆️

Copy link
Collaborator

@cjpillsbury cjpillsbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks 👌

@luwes luwes merged commit fd38722 into muxinc:main Aug 10, 2023
4 checks passed
@luwes luwes deleted the rendition-unavailable branch August 10, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants