Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: NaN valueAsNumber Safari error #967

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Conversation

luwes
Copy link
Contributor

@luwes luwes commented Sep 10, 2024

fix #947

@luwes luwes self-assigned this Sep 10, 2024
@luwes luwes requested review from heff and a team as code owners September 10, 2024 19:30
Copy link

vercel bot commented Sep 10, 2024

@luwes is attempting to deploy a commit to the Mux Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Sep 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
media-chrome ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 10, 2024 7:35pm

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 79.00%. Comparing base (3ea80df) to head (116fb9f).
Report is 95 commits behind head on main.

Files with missing lines Patch % Lines
src/js/media-time-range.ts 20.00% 4 Missing ⚠️
src/js/media-volume-range.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #967      +/-   ##
==========================================
+ Coverage   78.55%   79.00%   +0.45%     
==========================================
  Files          59       50       -9     
  Lines       11080    12057     +977     
  Branches        0      765     +765     
==========================================
+ Hits         8704     9526     +822     
- Misses       2376     2531     +155     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AdamJaggard AdamJaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@luwes luwes merged commit 3906cca into muxinc:main Sep 17, 2024
5 of 8 checks passed
@luwes luwes deleted the fix-value-as-number branch September 17, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

range.valueAsNumber operation is not supported
2 participants