Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: install Goreleaser to fix the release workflow #711

Merged
merged 4 commits into from
Oct 1, 2024

Conversation

suzuki-shunsuke
Copy link
Contributor

The release v0.1.14 failed due to the lack of GoReleaser.

https://github.com/mvisonneau/s5/releases/tag/v0.1.14

image

The release workflow failed.

https://github.com/mvisonneau/s5/actions/runs/11068634866/job/30754500864

Run make release
mkdir -p /home/runner/.cache/snapcraft/download
mkdir -p /home/runner/.cache/snapcraft/stage-packages
git tag -d edge
Deleted tag 'edge' (was 76[9](https://github.com/mvisonneau/s5/actions/runs/11068634866/job/30754500864#step:11:10)6960)
goreleaser release --clean
make: goreleaser: No such file or directory
make: *** [Makefile:39: release] Error [12](https://github.com/mvisonneau/s5/actions/runs/11068634866/job/30754500864#step:11:13)7
Error: Process completed with exit code 2.

GoReleaser was removed by this commit. a054bbd
I'm not sure why you removed GoReleaser, but GoReleaser is still necessary to release.

@suzuki-shunsuke suzuki-shunsuke marked this pull request as ready for review September 28, 2024 06:06
@mvisonneau
Copy link
Owner

oh indeed, thanks a ton @suzuki-shunsuke 🙇 !

@mvisonneau mvisonneau merged commit eb13718 into mvisonneau:main Oct 1, 2024
4 checks passed
@coveralls
Copy link

Coverage Status

coverage: 46.573%. remained the same
when pulling bfb7798 on suzuki-shunsuke:ci-install-goreleaser
into 7696960 on mvisonneau:main.

@suzuki-shunsuke suzuki-shunsuke deleted the ci-install-goreleaser branch October 2, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants