Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paint callback functionality improvements #306

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

PPakalns
Copy link
Contributor

Support executing additional render passes or adding command buffers from paint callback

@mvlabat
Copy link
Owner

mvlabat commented Aug 27, 2024

Hi, thanks for the PR!

Recently, we've also added this node: https://github.com/mvlabat/bevy_egui/blob/3aed12f9292d46c81a1cde1160198c6fb572e253/src/egui_render_to_texture_node.rs

It duplicates probably ~80% of egui_node.rs code, which I'm not a fan of. But until we refactor that, we'll have to introduce any changes to both of them.

@PPakalns
Copy link
Contributor Author

Logic added, feel free to edit branch if minor fixes are needed.

@PPakalns
Copy link
Contributor Author

Ping in case of missing this in github feed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants