Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add working example of consuming as bzlmod #36

Conversation

JohnRudolfLewis
Copy link

@JohnRudolfLewis JohnRudolfLewis commented Jul 30, 2024

Continues the work started by @hofbi in GH-33

@JohnRudolfLewis
Copy link
Author

@hofbi I was able to reproduce the inability to build with your changes in GH-33. A few more changes were needed.

Copy link
Contributor

@hofbi hofbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for providing the fix. I added it to #33, let's see who get's in first.

MODULE.bazel Outdated Show resolved Hide resolved
examples/bzlmod/MODULE.bazel Outdated Show resolved Hide resolved
examples/bzlmod/MODULE.bazel Outdated Show resolved Hide resolved
examples/bzlmod/MODULE.bazel Outdated Show resolved Hide resolved
@mvukov
Copy link
Owner

mvukov commented Aug 21, 2024

Addressed in #43 , I believe.

@mvukov mvukov closed this Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using rules_ros via bzlmod results in invalid label for module extension found
3 participants