Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bytes string when writing to dummy file #102

Merged
merged 4 commits into from
May 27, 2017

Conversation

saily
Copy link
Contributor

@saily saily commented Mar 27, 2017

Should basically fix #101

@coveralls
Copy link

coveralls commented Mar 27, 2017

Coverage Status

Coverage remained the same at 86.692% when pulling 71b88cf on saily:byte-str-as-filecontent into 03cf648 on mwarkentin:master.

@mwarkentin
Copy link
Owner

Need to do some testing with this on a Python 2.7 project before merging.

@saily
Copy link
Contributor Author

saily commented May 25, 2017

@mwarkentin any news on this, Travis seems to be fine on py2.7

@mwarkentin
Copy link
Owner

@saily Sorry about this, fell off my radar. Just tested on one of our py2.7 apps and it looks fine. I'll get a release out shortly.

Copy link
Owner

@mwarkentin mwarkentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@coveralls
Copy link

coveralls commented May 27, 2017

Coverage Status

Coverage remained the same at 86.742% when pulling 5692ad7 on saily:byte-str-as-filecontent into e3d5e53 on mwarkentin:master.

@coveralls
Copy link

coveralls commented May 27, 2017

Coverage Status

Coverage decreased (-0.05%) to 86.692% when pulling 5692ad7 on saily:byte-str-as-filecontent into e3d5e53 on mwarkentin:master.

@coveralls
Copy link

coveralls commented May 27, 2017

Coverage Status

Coverage remained the same at 86.742% when pulling 5692ad7 on saily:byte-str-as-filecontent into e3d5e53 on mwarkentin:master.

@mwarkentin mwarkentin merged commit a594323 into mwarkentin:master May 27, 2017
@mwarkentin
Copy link
Owner

@saily Ok, I've put 0.13.1 on pypi: https://pypi.python.org/pypi/django-watchman

Please give it a shot and let me know if it works for you or not!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

watchman.checks.storage should write bytes to test-file on Py3
3 participants