Add a new 'ping' endpoint #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhoffman34
force-pushed
the
add-ping-endpoint
branch
3 times, most recently
from
6844cd4
to
d363411
Compare
|
@mwarkentin @felixc Opened this PR. |
dhoffman34
force-pushed
the
add-ping-endpoint
branch
from
d363411
to
b7688a0
Compare
dhoffman34
force-pushed
the
add-ping-endpoint
branch
from
b7688a0
to
76efe58
Compare
mwarkentin
reviewed
Jan 5, 2018
watchman/views.py
Outdated
| @@ -69,6 +69,13 @@ def status(request): | |||
| return response, http_code, {WATCHMAN_VERSION_HEADER: __version__} | |||
|
|
|||
|
|
|||
| @non_atomic_requests | |||
There was a problem hiding this comment.
This is a django db transaction setting, probably not needed here?
There was a problem hiding this comment.
Hmm, yeah, not needed here. Updated to remove.
The endpoint simply returns the text 'pong' without running all of the checks.
dhoffman34
force-pushed
the
add-ping-endpoint
branch
from
76efe58
to
3847a89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The endpoint simply returns the text 'pong' without running all of the checks.