Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exclude from Datadog APM #142

Merged
merged 6 commits into from
Aug 19, 2019
Merged

exclude from Datadog APM #142

merged 6 commits into from
Aug 19, 2019

Conversation

robatwave
Copy link
Contributor

@coveralls
Copy link

coveralls commented Aug 17, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-1.7%) to 83.882% when pulling 4cd03e6 on robatwave:datadog-apm into 423d38c on mwarkentin:master.

@mwarkentin
Copy link
Owner

Awesome, thanks! Let me know if you need anything to test this (eg. dev release or whatever).

@robatwave
Copy link
Contributor Author

@mwarkentin yeah a dev release would probably be easiest

@mwarkentin
Copy link
Owner

Cool, ping me tomorrow and I’ll get that pushed for you.

@mwarkentin
Copy link
Owner

mwarkentin commented Aug 18, 2019 •
edited by unfurl-links bot
Loading

@robatwave I've pushed a dev release: https://pypi.org/project/django-watchman/#history

PyPI
django-watchman exposes a status endpoint for your backing services

@robatwave
Copy link
Contributor Author

@mwarkentin one more dev release please

@mwarkentin
Copy link
Owner

@robatwave pushed dev2

@robatwave robatwave marked this pull request as ready for review August 19, 2019 17:38
@mwarkentin
Copy link
Owner

mwarkentin commented Aug 19, 2019 •
edited by unfurl-links bot
Loading

@robatwave can you:

GitHub
django-watchman exposes a status endpoint for your backing services like databases, caches, etc. - mwarkentin/django-watchman
GitHub
django-watchman exposes a status endpoint for your backing services like databases, caches, etc. - mwarkentin/django-watchman

robatwave and others added 4 commits August 19, 2019 13:56
mwarkentin
mwarkentin approved these changes Aug 19, 2019
View reviewed changes
Copy link
Owner

@mwarkentin mwarkentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ryanwilsonperkin
Copy link
Contributor

Confirmed on my app!

@mwarkentin mwarkentin merged commit 1456520 into mwarkentin:master Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JBKahn JBKahn JBKahn left review comments

@mwarkentin mwarkentin mwarkentin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@robatwave @coveralls @mwarkentin @ryanwilsonperkin @JBKahn