Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump django-jsonview #40

Merged
merged 4 commits into from
Aug 14, 2015
Merged

Bump django-jsonview #40

merged 4 commits into from
Aug 14, 2015

Conversation

JBKahn
Copy link
Contributor

@JBKahn JBKahn commented Aug 14, 2015

Improved Django 1.8 compatibility.
It didn't drop any compatibility either
https://github.com/jsocol/django-jsonview/blob/ae393b13c54ee3a3eb1a1437ea44ea0adfbdf059/CHANGELOG#L11

@@ -10,6 +10,7 @@ env:
- DJANGO_VERSION=1.4.15
- DJANGO_VERSION=1.6.7
- DJANGO_VERSION=1.7.0
- DJANGO_VERSION=1.8.3
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind actually matching this up with the officially supported Django versions? Currently 1.4.x, 1.7.x, and 1.8.x - feel free to bump the 1.4.x / 1.7.x to the latest release as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do.

On Fri, Aug 14, 2015, 8:32 AM Michael Warkentin [email protected]
wrote:

In .travis.yml
#40 (comment)
:

@@ -10,6 +10,7 @@ env:

  • DJANGO_VERSION=1.4.15
  • DJANGO_VERSION=1.6.7
  • DJANGO_VERSION=1.7.0
      • DJANGO_VERSION=1.8.3

Would you mind actually matching this up with the officially supported
Django versions? Currently 1.4.x, 1.7.x, and 1.8.x - feel free to bump the
1.4.x / 1.7.x to the latest release as well.


Reply to this email directly or view it on GitHub
https://github.com/mwarkentin/django-watchman/pull/40/files#r37071695.

@mwarkentin
Copy link
Owner

Just the one comment, otherwise LGTM.

👍

@mwarkentin
Copy link
Owner

@JBKahn Looks good - is this something you need a release of quickly?

@JBKahn
Copy link
Contributor Author

JBKahn commented Aug 14, 2015

@mwarkentin when you have time it would be good :) but I suppose it can wait.

mwarkentin added a commit that referenced this pull request Aug 14, 2015
@mwarkentin mwarkentin merged commit 8346619 into mwarkentin:master Aug 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants