Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #73: Parse token from Authorization header #75

Merged
merged 3 commits into from
May 2, 2016
Merged

Fix #73: Parse token from Authorization header #75

merged 3 commits into from
May 2, 2016

Conversation

mwarkentin
Copy link
Owner

@mwarkentin mwarkentin commented Mar 7, 2016 •
edited
Loading

Start by trying to get the token from the header, fall back to the GET param.

Expected format: Authorization: WATCHMAN-TOKEN Token="ABC123"

Todo

  • Add tests
  • Update docs

@mwarkentin
Fix #73: Parse token from Authorization header
550a19a 
Start by trying to get the token from the header, fall back to the `GET` param.

Expected format: `Authorization: WATCHMAN-TOKEN Token="ABC123"`
@mwarkentin
Copy link
Owner Author

By analyzing the blame information on this pull request, we identified @none and @benwebber to be potential reviewers.

@mwarkentin mwarkentin mentioned this pull request May 2, 2016
Closed
@dlanger
Copy link

dlanger commented May 2, 2016

🚀

@coveralls
Copy link

coveralls commented May 2, 2016 •
edited
Loading

Coverage Status

Coverage increased (+2.6%) to 85.83% when pulling 323549a on 73-token-header into d8bc755 on master.

@mwarkentin mwarkentin merged commit b312843 into master May 2, 2016
@mwarkentin mwarkentin deleted the 73-token-header branch May 2, 2016 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mwarkentin @dlanger @coveralls