Add Grid.figure to (eventually) replace Grid.fig #2639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The advantage of this change is that you will be able to do
obj = sns.<func>()
obj.figure.<method>
regardless of whether is figure-level or axes-level.
The `Grid.fig` methods are being soft-deprecated: discouraged in the
attribute documentation but not (currently) issuing a warning when used.
Codecov Report
@@ Coverage Diff @@
## master #2639 +/- ##
==========================================
+ Coverage 97.43% 97.51% +0.07%
==========================================
Files 17 17
Lines 6405 6402 -3
==========================================
+ Hits 6241 6243 +2
+ Misses 164 159 -5
Continue to review full report at Codecov.
|
mwaskom
added a commit
that referenced
this pull request
Aug 14, 2021
* Add Grid.figure to (eventually) replace Grid.fig
The advantage of this change is that you will be able to do
obj = sns.<func>()
obj.figure.<method>
regardless of whether is figure-level or axes-level.
The `Grid.fig` methods are being soft-deprecated: discouraged in the
attribute documentation but not (currently) issuing a warning when used.
* Update docs, tests, and release notes
(cherry picked from commit 091f4c0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The advantage of this change is that you will be able to do
regardless of whether
<func>is figure-level or axes-level.The
Grid.figmethods are being soft-deprecated: discouraged in theattribute documentation but not (currently) issuing a warning when used.