Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with boolean values for color #3135

Closed
wants to merge 2 commits into from

Conversation

thuiop
Copy link
Contributor

@thuiop thuiop commented Nov 11, 2022

Fixes the bug from #3106 by using a Nominal scale for boolean instead of Continuous.

@mwaskom
Copy link
Owner

mwaskom commented Nov 11, 2022

I think this should be fixed in Continuous by making sure theres a cast to float before the subtraction. Then I also think there could be a Boolean or Binary scale type. I'm not sure about defaulting to Nominal.

@thuiop
Copy link
Contributor Author

thuiop commented Nov 11, 2022

I do agree that there could be a Boolean scale ; however, I do feel that boolean data is more at home with Nominal rather than Continuous as there is a discrete number of values.

@mwaskom
Copy link
Owner

mwaskom commented Nov 11, 2022

In any case, this is not the right place to add the default scale because color properties are not the only ones that run into the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants