Skip to content
This repository has been archived by the owner on Jul 8, 2020. It is now read-only.

scss module.scss #217

Closed
DrMabuse23 opened this issue Jul 23, 2015 · 4 comments
Closed

scss module.scss #217

DrMabuse23 opened this issue Jul 23, 2015 · 4 comments
Milestone

Comments

@DrMabuse23
Copy link
Contributor

yo m:module generate a module.scss not a _module.scss
Problem no variables are longer available!!!

@gruppjo
Copy link
Contributor

gruppjo commented Aug 6, 2015

Hi @DrMabuse23, can you please specify, what variables are you talking about, what is the use-case exactly?
Unless you're using sass in a way that I don't have in my mind right now, I don't see the problem. It's always been like this and the new modules and the scss integration have been implemented in the way we all discussed and agreed on. See #148

@DrMabuse23
Copy link
Contributor Author

I`am talking about the ionic variable and we discussed in the meeting that we want => module network => styles/_network.scss.

@gruppjo
Copy link
Contributor

gruppjo commented Aug 6, 2015

For the last release we agreed on these changes: #148 (comment)
We'll discuss this feature and put it on the roadmap accordingly

@gruppjo
Copy link
Contributor

gruppjo commented Sep 2, 2015

Discussion:

Mathias:

  • naming: module.scss rather main.scss, side.scss, etc...

Jonathan:

  • don't destroy newbie workflow:
    1. create module
    2. make css adjustments
    3. see live with livereload
  • don't create unnecessary complicated logic, try to find a solution that fits all

@gruppjo gruppjo added this to the 1.3.0 milestone Sep 2, 2015
@gruppjo gruppjo closed this as completed in 52c136b Sep 2, 2015
gruppjo added a commit to mwaylabs/generator-m-ionic-demo that referenced this issue Sep 2, 2015
gruppjo added a commit that referenced this issue Sep 2, 2015
gruppjo added a commit to mwaylabs/generator-m-ionic-demo that referenced this issue Sep 2, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants