Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid creating default state machine role when an external role is set #170

Merged
merged 1 commit into from
Mar 9, 2020

Conversation

swinz
Copy link
Contributor

@swinz swinz commented Mar 8, 2020

When a lambda step is present in the state machine and an external role is supplied via StateMachine.WithRoleArn(), the role used by the StateMachine is the default one instead of the one supplied.

This change avoids creating and using the default role in cases when the role is supplied explicitly.

@mweagle
Copy link
Owner

mweagle commented Mar 9, 2020

lgtm - thanks @swinz

@mweagle mweagle merged commit a4b74cc into mweagle:master Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants