-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
question on deprecation re Rsolr::Ext.connect #15
Comments
Hey Jonathan. When you require rsolr-ext, it automatically overrides code in rsolr. I think being explicit about using rsolr-ext functionality is best. The change makes it so that rsolr-ext does not override rsolr when loading the library. Using RSolr::Ext.connect fixes this. You don't have to do anything in Blacklight, it's already there: https://github.com/projectblacklight/blacklight/blob/master/lib/blacklight.rb#L62 |
Hmm, something does not compute. If it's already there, why am I getting the deprecation warning on If I'm getting a deprecation warning, my assumption is I'm (or BL On Mon, Jun 6, 2011 at 5:27 PM, mwmitchell
|
Hmm, I was wrong about this. I'm removing the warning. The only thing RSolr::Ext#connect is doing is wrapping RSolr#connect. The thing I don't like is the auto-mixin when rsolr-ext is loaded. But if you're loading it, you want to use it. |
Awesome, thanks. I don't entirely get the thing you don't like, but if (In upgrading my app from rails2/blacklight2 to blacklight/rails3, I On Jun 6, 2011, at 11:06 PM, mwmitchell wrote:
|
When starting up a Blacklight app that uses RSolr::Ext, I get this:
"DEPRECATION WARNING: Future versions of RSolr::Ext will require initialization via RSolr::Ext.connect."
Can you explain what the deprecated behavior is exactly, and what the non-deprecated alternative is? How should I fix Blacklight code to not trigger this deprecation warning (and more importantly, be future-forward and not be using deprecated behavior).
Thanks.
The text was updated successfully, but these errors were encountered: