Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not deploy top-level "tests" directory #184

Closed
jhermann opened this issue Feb 20, 2019 · 1 comment
Closed

Do not deploy top-level "tests" directory #184

jhermann opened this issue Feb 20, 2019 · 1 comment
Milestone
1.0.1

Comments

@jhermann
Copy link

You might want to consider changing your find_packages call to this:

find_packages(exclude=['tests']),

Since otherwise you install "tests" into the global namespace.
@mwouts
Copy link
Owner

mwouts commented Feb 20, 2019

Hello @jhermann , thanks for your suggestion. Yes I agree, we should improve this. Actually I am not sure I know what the best practice is here... Would you advice to move the tests directory under jupytext? Or remove the tests overall from the pip and conda packages?

mwouts added a commit that referenced this issue Feb 21, 2019
@mwouts
Do not deploy top-level "tests" directory #184
f432697
@mwouts mwouts added this to the 1.0.1 milestone Feb 21, 2019
mwouts added a commit that referenced this issue Feb 23, 2019
@mwouts
Do not deploy top-level "tests" directory #184
3aaa7f1
@mwouts mwouts mentioned this issue Feb 23, 2019
Merged
@mwouts mwouts closed this as completed Feb 23, 2019
@mwouts mwouts mentioned this issue Aug 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.1
Development

No branches or pull requests
2 participants
@jhermann @mwouts