Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conda build for Jupytext 1.2.2 is in error #323

Closed
mwouts opened this issue Sep 1, 2019 · 4 comments · Fixed by #324
Closed

Conda build for Jupytext 1.2.2 is in error #323

mwouts opened this issue Sep 1, 2019 · 4 comments · Fixed by #324

Comments

@mwouts
Copy link
Owner

mwouts commented Sep 1, 2019

As pkg_ressources imported in pandoc.py in not an explicit dependency.

This may be a side effect of #310 .

Below is an extract of the logs:

Packaging jupytext
INFO:conda_build.build:Packaging jupytext
INFO conda_build.build:build(1570): Packaging jupytext
INFO:conda_build.build:Packaging jupytext-1.2.2-0
INFO conda_build.build:bundle_conda(891): Packaging jupytext-1.2.2-0
Packaging jupytext-1.2.2-0
number of files: 43
Fixing permissions
Packaged license file/s.
Importing conda-verify failed.  Please be sure to test your packages.  conda install conda-verify to make this message go away.
WARNING:conda_build.build:Importing conda-verify failed.  Please be sure to test your packages.  conda install conda-verify to make this message go away.
WARNING conda_build.build:bundle_conda(1042): Importing conda-verify failed.  Please be sure to test your packages.  conda install conda-verify to make this message go away.
TEST START: /home/conda/feedstock_root/build_artifacts/noarch/jupytext-1.2.2-0.tar.bz2
Adding in variants from /tmp/tmphdeivyu7/info/recipe/conda_build_config.yaml
INFO:conda_build.variants:Adding in variants from /tmp/tmphdeivyu7/info/recipe/conda_build_config.yaml
INFO conda_build.variants:_combine_spec_dictionaries(188): Adding in variants from /tmp/tmphdeivyu7/info/recipe/conda_build_config.yaml
Renaming work directory,  /home/conda/feedstock_root/build_artifacts/jupytext_1567359616966/work  to  /home/conda/feedstock_root/build_artifacts/jupytext_1567359616966/work_moved_jupytext-1.2.2-0_noarch
Collecting package metadata (repodata.json): ...working... done
Solving environment: ...working... done

## Package Plan ##

  environment location: /home/conda/feedstock_root/build_artifacts/jupytext_1567359616966/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho


The following NEW packages will be INSTALLED:

    _libgcc_mutex:    0.1-main             defaults   
    bzip2:            1.0.8-h516909a_0     conda-forge
    ca-certificates:  2019.6.16-hecc5488_0 conda-forge
    decorator:        4.4.0-py_0           conda-forge
    ipython_genutils: 0.2.0-py_1           conda-forge
    jsonschema:       2.6.0-py37_1002      conda-forge
    jupyter_core:     4.4.0-py_0           conda-forge
    jupytext:         1.2.2-0              local      
    libffi:           3.2.1-he1b5a44_1006  conda-forge
    libgcc-ng:        9.1.0-hdf63c60_0     defaults   
    libstdcxx-ng:     9.1.0-hdf63c60_0     defaults   
    nbformat:         4.4.0-py_1           conda-forge
    ncurses:          6.1-hf484d3e_1002    conda-forge
    openssl:          1.1.1c-h516909a_0    conda-forge
    python:           3.7.3-h33d41f4_1     conda-forge
    pyyaml:           5.1.2-py37h516909a_0 conda-forge
    readline:         8.0-hf8c457e_0       conda-forge
    six:              1.12.0-py37_1000     conda-forge
    sqlite:           3.29.0-hcee41ef_1    conda-forge
    tk:               8.6.9-hed695b0_1002  conda-forge
    traitlets:        4.3.2-py37_1000      conda-forge
    xz:               5.2.4-h14c3975_1001  conda-forge
    yaml:             0.1.7-h14c3975_1001  conda-forge
    zlib:             1.2.11-h516909a_1005 conda-forge

Preparing transaction: ...working... done
Verifying transaction: ...working... done
Executing transaction: ...working... done
export PREFIX=/home/conda/feedstock_root/build_artifacts/jupytext_1567359616966/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho
export SRC_DIR=/home/conda/feedstock_root/build_artifacts/jupytext_1567359616966/test_tmp
import: 'jupytext'
Traceback (most recent call last):
  File "/home/conda/feedstock_root/build_artifacts/jupytext_1567359616966/test_tmp/run_test.py", line 2, in <module>
    import jupytext
  File "/home/conda/feedstock_root/build_artifacts/jupytext_1567359616966/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/lib/python3.7/site-packages/jupytext/__init__.py", line 3, in <module>
    from .jupytext import read, write, readf, writef, writes, reads
  File "/home/conda/feedstock_root/build_artifacts/jupytext_1567359616966/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/lib/python3.7/site-packages/jupytext/jupytext.py", line 12, in <module>
    from .formats import _VALID_FORMAT_OPTIONS
  File "/home/conda/feedstock_root/build_artifacts/jupytext_1567359616966/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/lib/python3.7/site-packages/jupytext/formats.py", line 19, in <module>
    from .pandoc import pandoc_version, is_pandoc_available
  File "/home/conda/feedstock_root/build_artifacts/jupytext_1567359616966/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/lib/python3.7/site-packages/jupytext/pandoc.py", line 8, in <module>
    from pkg_resources import parse_version
ModuleNotFoundError: No module named 'pkg_resources'
Tests failed for jupytext-1.2.2-0.tar.bz2 - moving package to /home/conda/feedstock_root/build_artifacts/broken
WARNING:conda_build.build:Tests failed for jupytext-1.2.2-0.tar.bz2 - moving package to /home/conda/feedstock_root/build_artifacts/broken
WARNING conda_build.build:tests_failed(2230): Tests failed for jupytext-1.2.2-0.tar.bz2 - moving package to /home/conda/feedstock_root/build_artifacts/broken
TESTS FAILED: jupytext-1.2.2-0.tar.bz2
##[error]Bash exited with code '1'.
##[section]Finishing: Run docker build
@grst
Copy link
Contributor

grst commented Sep 2, 2019

Having seen the diff of #310, I doubt that it's related to that one.

The error message ModuleNotFoundError: No module named 'pkg_resources' hints at that setuptools is not available in the test env. Did you change the dependencies lately?

@mwouts
Copy link
Owner Author

mwouts commented Sep 2, 2019

Thank you @grst. Well, I'm not sure where this comes from.

There has been no change in pandoc.py (where the error occurs) in the last 5 months. And Jupytext's requirements last changed two months ago.

I was thinking of #310 because the tests are the only place where we do import Jupytext's pandoc.py, and the point in #310 was to include the tests in the package. So maybe the conda build now also runs Jupytext's tests? Which, indeed, should raise the missing dependency?

@grst
Copy link
Contributor

grst commented Sep 2, 2019

So maybe the conda build now also runs Jupytext's tests? Which, indeed, should raise the missing dependency?

That's probably it - conda now tries to runs the tests as they are available. I think that's not a bad thing... so just update the test dependencies in meta.yml?

@mwouts
Copy link
Owner Author

mwouts commented Sep 2, 2019

Good idea! I'll try that. Thanks @grst.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants