Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Add mypy #1194

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from
Draft

ci: Add mypy #1194

wants to merge 21 commits into from

Conversation

LecrisUT
Copy link
Contributor

@LecrisUT LecrisUT commented Dec 5, 2023

None of the code is type-hinted, so there would be some effort to go through for this one. But at least here is the tooling if you want to steadily tackle it

@LecrisUT
Remove concurrency
2597782 
Only the workflows that trigger need the concurrency
@LecrisUT
Update action versions
4746798
@LecrisUT
Reorganize test dependencies
a4482e2
@LecrisUT
Harden the workflows
75c9bc9
@LecrisUT
Update python-version defaults
8ceee0d 
Signed-off-by: Cristian Le <[email protected]>
@LecrisUT
Remove explicit markdown-it-py
37b91ad
@LecrisUT
Simplify release CI
c65f6a1
@LecrisUT
Improve CI display
01f9e84
@LecrisUT
Add pass action
b7a57ae 
Signed-off-by: Cristian Le <[email protected]>
@LecrisUT
Simplify step_build
c823401
@LecrisUT
Remove the sdist.exclude
6bbe1be
@LecrisUT
Remove jupyterlab upper-bound
e61b1c5
@LecrisUT
Add missing .git_archival.txt
db0f0c6 
See https://setuptools-scm.readthedocs.io/en/latest/usage/#git-archives
@LecrisUT
Configure fail-fast option
d7f6fbf 
Signed-off-by: Cristian Le <[email protected]>
@LecrisUT
Bump minimum markdown-it-py
a687e07 
Signed-off-by: Cristian Le <[email protected]>
@LecrisUT
fix markdown-it-py-version CI
5b14f44 
Signed-off-by: Cristian Le <[email protected]>
@LecrisUT
Package name convention
cd46148 
Signed-off-by: Cristian Le <[email protected]>
@LecrisUT
Configure release CD
9416e98 
Signed-off-by: Cristian Le <[email protected]>
@LecrisUT
Run pytest in parallel
e7a3503 
Signed-off-by: Cristian Le <[email protected]>
@LecrisUT
Reconfigure codecov
903e871 
Signed-off-by: Cristian Le <[email protected]>
@LecrisUT
Add mypy
d3e0793 
Signed-off-by: Cristian Le <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023

Thank you for making this pull request.

Did you know? You can try it on Binder: Binder:lab or Binder:notebook.

Also, the version of Jupytext developed in this PR can be installed with pip:

pip install git+https://github.com/LecrisUT/jupytext.git@ci/mypy

(this requires nodejs, see more at Developing Jupytext)

@mwouts mwouts added this to the 1.17.0 milestone Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.
2 participants
@LecrisUT @mwouts