Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix re.split DeprecationWarning #1241

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Fix re.split DeprecationWarning #1241

merged 1 commit into from
Jul 9, 2024

Conversation

jamesjer
Copy link
Contributor

Silences this DeprecationWarning with python 3.13.0b2:

  /builddir/build/BUILD/python-jupytext-1.16.2-build/BUILDROOT/usr/lib/python3.13/site-packages/jupytext/cell_metadata.py:260: DeprecationWarning: 'maxsplit' is passed as positional argument
    options = re.split(r"\s|,", options, 1)

Copy link

Thank you for making this pull request.

Did you know? You can try it on Binder: Binder:lab or Binder:notebook.

Also, the version of Jupytext developed in this PR can be installed with pip:

HATCH_BUILD_HOOKS_ENABLE=true pip install git+https://github.com/jamesjer/jupytext.git@main

(this requires nodejs, see more at Developing Jupytext)

Copy link

codecov bot commented Jun 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.73%. Comparing base (42a48e8) to head (89c450e).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1241   +/-   ##
=======================================
  Coverage   97.73%   97.73%           
=======================================
  Files          29       29           
  Lines        4468     4468           
=======================================
  Hits         4367     4367           
  Misses        101      101           
Flag Coverage Δ
external 75.14% <100.00%> (+0.09%) ⬆️
functional 88.52% <100.00%> (ø)
integration 77.28% <100.00%> (ø)
unit 66.56% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mwouts mwouts merged commit cda2cb4 into mwouts:main Jul 9, 2024
32 checks passed
@mwouts
Copy link
Owner

mwouts commented Jul 9, 2024

Thank you @jamesjer for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants