Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use non-random cell ids in tests #751

Merged
merged 2 commits into from
Mar 7, 2021
Merged

Conversation

mwouts
Copy link
Owner

@mwouts mwouts commented Mar 5, 2021

This should fix #747

@codecov
Copy link

codecov bot commented Mar 5, 2021

Codecov Report

Merging #751 (397ea69) into master (58e8b27) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #751   +/-   ##
=======================================
  Coverage   99.10%   99.10%           
=======================================
  Files         105      106    +1     
  Lines        9926     9939   +13     
=======================================
+ Hits         9837     9850   +13     
  Misses         89       89           
Impacted Files Coverage Δ
tests/conftest.py 100.00% <100.00%> (ø)
tests/test_cell_id.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58e8b27...397ea69. Read the comment docs.

@mwouts mwouts force-pushed the non_random_cell_ids_in_tests branch from 550b490 to 397ea69 Compare March 7, 2021 18:50
@mwouts mwouts merged commit 593bcef into master Mar 7, 2021
@mwouts mwouts deleted the non_random_cell_ids_in_tests branch March 7, 2021 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Random failures in tests due to duplicate cell ids
1 participant