Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix possible ambiguous use of when(fulfilled:) in tests #1171

Merged
merged 2 commits into from
May 24, 2021
Merged

Fix possible ambiguous use of when(fulfilled:) in tests #1171

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
508c181
Fix possible ambiguous use of when(fulfilled:)
RomanPodymov Oct 6, 2020
da7895d
Merge pull request #5 from mxcl/master
RomanPodymov May 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Tests/CorePromise/WhenTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,8 @@ class WhenTests: XCTestCase {
let p2 = after(.milliseconds(100)).done { throw Error.straggler }
let p3 = after(.milliseconds(200)).done { throw Error.straggler }

when(fulfilled: p1, p2, p3).catch { error -> Void in
let whenFulfilledP1P2P3: Promise<(Void, Void, Void)> = when(fulfilled: p1, p2, p3)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There can be also let whenFulfilledP1P2P3: Promise<Void> = when(fulfilled: p1, p2, p3).

whenFulfilledP1P2P3.catch { error -> Void in
XCTAssertTrue(Error.test == error as? Error)
ex1.fulfill()
}
Expand All @@ -241,7 +242,8 @@ class WhenTests: XCTestCase {
let p2 = Promise<Void>(error: Error.test2)
let p3 = Promise<Void>(error: Error.test3)

when(fulfilled: p1, p2, p3).catch { error in
let whenFulfilledP1P2P3: Promise<Void> = when(fulfilled: p1, p2, p3)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There can be also let whenFulfilledP1P2P3: Promise<(Void, Void, Void)> = when(fulfilled: p1, p2, p3).

whenFulfilledP1P2P3.catch { error in
XCTAssertTrue(error as? Error == Error.test1)
ex.fulfill()
}
Expand Down