Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

func race(fulfilled:) for Objective-C #1269

Merged
merged 3 commits into from
Sep 24, 2021
Merged

func race(fulfilled:) for Objective-C #1269

merged 3 commits into from
Sep 24, 2021

Conversation

RomanPodymov
Copy link
Collaborator

Hello.
Thank you for PromiseKit.
Add func race(fulfilled:) for Objective-C.

@@ -91,7 +91,6 @@ public func race<U: Thenable>(fulfilled thenables: [U]) -> Promise<U.T> {
}
case .fulfilled(let value):
guard rp.isPending else { return }
countdown = 0
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An unnecessary line.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, but there is no reason to remove it. It is possible this is required. Please leave it.

@mxcl mxcl merged commit 2ff9793 into mxcl:v6 Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants