Moved set_is_ready
with deprecation warning to HardwareObject.
#1000
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Device
object defines three methods in addition to those defined onHardwareObject
.HardwareObject
Device
userName()
in the code base)Some objects that inherited
Device
where using the method calledset_is_ready
taking a boolean with the "ready state".set_is_ready
was moved to HardwareObject, with a deprecation warning. The logic ofset_is_ready
was translated to internally work with the states defined inHardwareObjectState
(still taking a boolean argument)The semantics of is_ready and set_is_ready should thus be compatible with that originally defined on
Device
.I will leave it up to each site to replace
set_is_ready
with the corresponding call toself.update_state(HardwareObjectState.READY)
and then depending on the situationself.update_state(HardwareObjectState.BUSY|OFF)
. Theset_is_ready
method defined onHardwareObject
usesHardwareObjectState.OFF
.Closes #1372