Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] P11 develop upgrade #854

Closed
wants to merge 165 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
165 commits
Select commit Hold shift + click to select a range
e80379d
Fixing the ambiguity with Poller value and .any
Sep 18, 2023
5f29dc6
P11Collect additional debug after upgrade
Sep 18, 2023
d2b8c35
Fixing the ambiguity with Poller value and .any
Sep 18, 2023
ba7d34c
P11Collect additional debug after upgrade
Sep 18, 2023
9585b03
Merge remote-tracking branch 'origin/p11_develop' into p11_develop
Sep 27, 2023
df5dfd3
Force upgrade from the develop to avoid merging conflict
Sep 27, 2023
de981e7
Added missing warnings module
Sep 27, 2023
24c07c7
Enabled back explicit check on if beamtimeid is open
Sep 27, 2023
d22d705
Added debug info in case beamtime ID is not opened
Sep 27, 2023
4a38247
Added beamtime info as a property
Sep 27, 2023
480ec3e
Added additional debug messages for shutter
Sep 27, 2023
56d2cad
Fixed get_properties naming (Bixente)
Sep 27, 2023
a07b2ec
Removed faulty login_type=user fot P11
Sep 27, 2023
be6c170
Removed is_open() as a function and assigned is_closed() as a propert…
Sep 27, 2023
3e58e8d
Added is_open as a property inside P11NanoDiff (Bixente)
Sep 27, 2023
2a6a21e
Fixed other get_properties typos which were preventing loading
Sep 27, 2023
5d7ca11
Removed faulty login_type=user for P11
Sep 27, 2023
c20ec81
Removed is_open() as a function and assigned is_closed() as a propert…
Sep 27, 2023
7574477
Added is_open as a property inside P11NanoDiff (Bixente)
Sep 27, 2023
b4b8f9b
Fixed other get_properties typos which were preventing loading
Sep 27, 2023
4a192df
Merge remote-tracking branch 'origin/p11_develop' into p11_develop
Sep 29, 2023
f3bd7d5
Fixed shutter openning wainting forever (Bixente)
Oct 5, 2023
6fe81ab
Merge remote-tracking branch 'origin/p11_develop' into p11_develop
Oct 5, 2023
75621a3
Added preliminary flux HO for P11
Oct 6, 2023
30ddf3a
Upgraded the characterisation part for P11 using EDNA
Oct 6, 2023
e878dfb
Linting
Oct 6, 2023
7a11684
Add empty store_robot_action for P11 (temp fix due to ISPyB tests).
Oct 17, 2023
3fe9dff
Fix in AbstractSampleChanger that was causing sample not loaded error…
Oct 25, 2023
2d31d70
Fixing the ambiguity with Poller value and .any
Sep 18, 2023
8011a9c
P11Collect additional debug after upgrade
Sep 18, 2023
7def003
Force upgrade from the develop to avoid merging conflict
Sep 27, 2023
0451f47
Added missing warnings module
Sep 27, 2023
f4ea552
Enabled back explicit check on if beamtimeid is open
Sep 27, 2023
3f16e79
Added debug info in case beamtime ID is not opened
Sep 27, 2023
832f6e7
Added beamtime info as a property
Sep 27, 2023
0dc5d28
Added additional debug messages for shutter
Sep 27, 2023
d62e6bf
Fixed get_properties naming (Bixente)
Sep 27, 2023
44491ab
Removed faulty login_type=user fot P11
Sep 27, 2023
d652b9c
Removed is_open() as a function and assigned is_closed() as a propert…
Sep 27, 2023
8a03c76
Added is_open as a property inside P11NanoDiff (Bixente)
Sep 27, 2023
14e9de0
Fixed other get_properties typos which were preventing loading
Sep 27, 2023
fb4f534
Fixed shutter openning wainting forever (Bixente)
Oct 5, 2023
d002f93
Added preliminary flux HO for P11
Oct 6, 2023
3575ae9
Upgraded the characterisation part for P11 using EDNA
Oct 6, 2023
4dafa5b
Linting
Oct 6, 2023
b807078
Add empty store_robot_action for P11 (temp fix due to ISPyB tests).
Oct 17, 2023
ae9588f
Fix in AbstractSampleChanger that was causing sample not loaded error…
Oct 25, 2023
62ccaba
Merge remote-tracking branch 'origin/p11_develop' into p11_develop
Oct 25, 2023
5dabc0f
Added new HO for the beam representation for P11 (Bixente)
Oct 25, 2023
7e3188b
Fix beam position update in P11 Nanodiff
Nov 8, 2023
75ad89c
Minor changes
Nov 8, 2023
b2f3c7c
Added slits gap None (no slits) for P11 (Bixente)
Nov 8, 2023
2fd8ad5
Temp fix for P11 specific routine
Nov 8, 2023
3d4f0d2
Fixing the ambiguity with Poller value and .any
Sep 18, 2023
2b7e1fa
P11Collect additional debug after upgrade
Sep 18, 2023
9476766
Force upgrade from the develop to avoid merging conflict
Sep 27, 2023
77fe447
Added missing warnings module
Sep 27, 2023
b7c2e64
Enabled back explicit check on if beamtimeid is open
Sep 27, 2023
47c6c2c
Added debug info in case beamtime ID is not opened
Sep 27, 2023
0177daf
Added beamtime info as a property
Sep 27, 2023
cf28f6c
Added additional debug messages for shutter
Sep 27, 2023
1e62320
Fixed get_properties naming (Bixente)
Sep 27, 2023
dd41e29
Removed faulty login_type=user fot P11
Sep 27, 2023
b7e7294
Removed is_open() as a function and assigned is_closed() as a propert…
Sep 27, 2023
abb9df8
Added is_open as a property inside P11NanoDiff (Bixente)
Sep 27, 2023
b3c2ec3
Fixed other get_properties typos which were preventing loading
Sep 27, 2023
33b70bf
Fixed shutter openning wainting forever (Bixente)
Oct 5, 2023
3b56eaf
Added preliminary flux HO for P11
Oct 6, 2023
07a6e6a
Upgraded the characterisation part for P11 using EDNA
Oct 6, 2023
69f7734
Linting
Oct 6, 2023
72d1966
Add empty store_robot_action for P11 (temp fix due to ISPyB tests).
Oct 17, 2023
518f517
Fix in AbstractSampleChanger that was causing sample not loaded error…
Oct 25, 2023
a3a645d
Fixing the ambiguity with Poller value and .any
Sep 18, 2023
732d330
P11Collect additional debug after upgrade
Sep 18, 2023
dbf92d1
Force upgrade from the develop to avoid merging conflict
Sep 27, 2023
2b0d5e9
Removed is_open() as a function and assigned is_closed() as a propert…
Sep 27, 2023
2475e32
Upgraded the characterisation part for P11 using EDNA
Oct 6, 2023
738f981
Linting
Oct 6, 2023
d0bec06
Added new HO for the beam representation for P11 (Bixente)
Oct 25, 2023
9a07a93
Fix beam position update in P11 Nanodiff
Nov 8, 2023
4112629
Minor changes
Nov 8, 2023
ab9ec24
Added slits gap None (no slits) for P11 (Bixente)
Nov 8, 2023
f86bc95
Temp fix for P11 specific routine
Nov 8, 2023
7c64161
Merge remote-tracking branch 'origin/p11_develop' into p11_develop
Nov 8, 2023
349bda9
Renamed get_properties to get_properties_ as before and made appropri…
Nov 8, 2023
8037795
Merge branch 'p11_develop' of https://github.com/agruzinov/mxcubecore…
Nov 8, 2023
8ee4cc4
Cleanup unused code (PR800)
Nov 8, 2023
50be287
Fixing the ambiguity with Poller value and .any
Sep 18, 2023
888ec97
P11Collect additional debug after upgrade
Sep 18, 2023
a091d6f
Fixing the ambiguity with Poller value and .any
Sep 18, 2023
a01d46e
Force upgrade from the develop to avoid merging conflict
Sep 27, 2023
8414e3f
Added missing warnings module
Sep 27, 2023
3d8eaa8
Enabled back explicit check on if beamtimeid is open
Sep 27, 2023
2d02ae3
Added debug info in case beamtime ID is not opened
Sep 27, 2023
988c3c5
Added beamtime info as a property
Sep 27, 2023
ead7953
Added additional debug messages for shutter
Sep 27, 2023
40250bd
Fixed get_properties naming (Bixente)
Sep 27, 2023
ae8b878
Removed faulty login_type=user fot P11
Sep 27, 2023
13f14b8
Removed is_open() as a function and assigned is_closed() as a propert…
Sep 27, 2023
b021661
Added is_open as a property inside P11NanoDiff (Bixente)
Sep 27, 2023
f31ed83
Fixed other get_properties typos which were preventing loading
Sep 27, 2023
9aa5e33
Fixed shutter openning wainting forever (Bixente)
Oct 5, 2023
859bbf8
Added preliminary flux HO for P11
Oct 6, 2023
e095b64
Upgraded the characterisation part for P11 using EDNA
Oct 6, 2023
3965257
Linting
Oct 6, 2023
41adec3
Add empty store_robot_action for P11 (temp fix due to ISPyB tests).
Oct 17, 2023
3956097
Fix in AbstractSampleChanger that was causing sample not loaded error…
Oct 25, 2023
c3b5452
Fixing the ambiguity with Poller value and .any
Sep 18, 2023
5d45193
P11Collect additional debug after upgrade
Sep 18, 2023
81f2018
Force upgrade from the develop to avoid merging conflict
Sep 27, 2023
dbbe6d4
Enabled back explicit check on if beamtimeid is open
Sep 27, 2023
a801746
Added debug info in case beamtime ID is not opened
Sep 27, 2023
9f87b9d
Added additional debug messages for shutter
Sep 27, 2023
d5230fc
Removed is_open() as a function and assigned is_closed() as a propert…
Sep 27, 2023
fa994b1
Fixed shutter openning wainting forever (Bixente)
Oct 5, 2023
deb07e9
Added preliminary flux HO for P11
Oct 6, 2023
1aeb1f7
Upgraded the characterisation part for P11 using EDNA
Oct 6, 2023
23922d2
Linting
Oct 6, 2023
5fd5872
Added new HO for the beam representation for P11 (Bixente)
Oct 25, 2023
55100bc
Fix beam position update in P11 Nanodiff
Nov 8, 2023
73c9a05
Minor changes
Nov 8, 2023
a8d8fdf
Added slits gap None (no slits) for P11 (Bixente)
Nov 8, 2023
32c0666
Temp fix for P11 specific routine
Nov 8, 2023
2e722cc
Fixing the ambiguity with Poller value and .any
Sep 18, 2023
8f1755e
P11Collect additional debug after upgrade
Sep 18, 2023
2a41443
Force upgrade from the develop to avoid merging conflict
Sep 27, 2023
198be99
Added debug info in case beamtime ID is not opened
Sep 27, 2023
554d003
Added additional debug messages for shutter
Sep 27, 2023
4d320cc
Removed is_open() as a function and assigned is_closed() as a propert…
Sep 27, 2023
22f4a2a
Fixed shutter openning wainting forever (Bixente)
Oct 5, 2023
0076681
Added preliminary flux HO for P11
Oct 6, 2023
4f0dc72
Upgraded the characterisation part for P11 using EDNA
Oct 6, 2023
e9e7f7b
Linting
Oct 6, 2023
f6dc76d
Fixing the ambiguity with Poller value and .any
Sep 18, 2023
e7aa787
P11Collect additional debug after upgrade
Sep 18, 2023
01a26e9
Force upgrade from the develop to avoid merging conflict
Sep 27, 2023
1c72ab6
Removed is_open() as a function and assigned is_closed() as a propert…
Sep 27, 2023
bd966b3
Upgraded the characterisation part for P11 using EDNA
Oct 6, 2023
a25eaf7
Linting
Oct 6, 2023
0f434cb
Temp fix for P11 specific routine
Nov 8, 2023
e3fe513
Renamed get_properties to get_properties_ as before and made appropri…
Nov 8, 2023
50c6b83
Cleanup unused code (PR800)
Nov 8, 2023
8dcf8b4
Remove conflicts
Nov 15, 2023
1c872e6
Linting
Nov 15, 2023
46b4fe5
Linting
Nov 15, 2023
dfb0cb4
Removed unused file
Nov 15, 2023
13bfad3
Removed unused DigitalZoomMotor.py
Nov 15, 2023
85c4862
Removed unused Centring.py
Nov 15, 2023
85bc098
Put back deleted by mistake class
Nov 27, 2023
f03f779
Added guard variable to avoind recirsion error after sample loading i…
Nov 27, 2023
37b6915
Bugfix for osc_start always initialised as None in case default param…
Dec 2, 2023
b35f10f
Fixed add_h5_info function in case the file is already existing
Dec 2, 2023
31cd0b8
Changed path conversion in P11Characterisation.py
Dec 2, 2023
1bba3ed
Modified the way additional shutter values are handeled (PR800)
Dec 2, 2023
8686c65
Run black
Dec 2, 2023
c3a2a03
Disabled additional logging
Dec 2, 2023
3f63381
Remove unnessesary triggerring of autoprocessing. It is triggered aut…
Dec 12, 2023
1a0b15e
Set omega to 0 at the end explicitly
Dec 12, 2023
44d8f09
Merge branch 'mxcube:develop' into p11_develop
agruzinov Feb 20, 2024
8724852
Explicit int after test run on Deb12
Feb 20, 2024
4bccd2c
Merge branch 'mxcube:develop' into p11_develop
agruzinov Feb 20, 2024
d215a03
Removed duplocated import PR854
Feb 20, 2024
bb7335e
Corrected call of osc_start PR854
Feb 21, 2024
33759a9
Code cleanup for super() in init (PR854)
Feb 21, 2024
e56e821
Corrected osc_start is not in the params dictionary (PR854)
Feb 21, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions mxcubecore/Command/Tango.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,7 @@
import queue


from mxcubecore.CommandContainer import (
CommandObject,
ChannelObject,
ConnectionError,
)
from mxcubecore.CommandContainer import CommandObject, ChannelObject, ConnectionError
from mxcubecore import Poller
from mxcubecore.dispatcher import saferef
import numpy
Expand Down Expand Up @@ -171,13 +167,13 @@ def __init__(
self.timeout = int(timeout)
self.read_as_str = kwargs.get("read_as_str", False)
self._device_initialized = gevent.event.Event()
#logging.getLogger("HWR").debug(
# logging.getLogger("HWR").debug(
# "creating Tango attribute %s/%s, polling=%s, timeout=%d",
# self.device_name,
# self.attribute_name,
# polling,
# self.timeout,
#)
# )
self.init_device()
self.continue_init(None)
"""
Expand Down
23 changes: 10 additions & 13 deletions mxcubecore/HardwareObjects/Beamline.py
Original file line number Diff line number Diff line change
Expand Up @@ -240,8 +240,8 @@ def _get_id_dict_rec(

return _path


# Signal handling functions:

def emit(self, signal: Union[str, object, Any], *args) -> None:
"""Emit signal. Accepts both multiple args and a single tuple of args.

Expand Down Expand Up @@ -291,7 +291,6 @@ def machine_info(self):

__content_roles.append("machine_info")


@property
def authenticator(self):
"""Authenticator Hardware object
Expand Down Expand Up @@ -774,9 +773,9 @@ def get_default_acquisition_parameters(self, acquisition_type="default"):

acq_parameters = queue_model_objects.AcquisitionParameters()

#logging.getLogger("HWR").debug(f"""
#Beamline object. Getting acquisition parameters for acquisition type {acquisition_type}
#""")
# logging.getLogger("HWR").debug(f"""
# Beamline object. Getting acquisition parameters for acquisition type {acquisition_type}
# """)

params = self.default_acquisition_parameters["default"].copy()
if acquisition_type != "default":
Expand All @@ -790,19 +789,17 @@ def get_default_acquisition_parameters(self, acquisition_type="default"):

params.update(dd0)

#logging.getLogger("HWR").debug(f"""
#params are {params}
#""")
# logging.getLogger("HWR").debug(f"""
# params are {params}
# """)

for tag, val in params.items():
setattr(acq_parameters, tag, val)

motor_positions = self.diffractometer.get_positions()
osc_start = (
None
if not params["osc_start"]
else motor_positions.get("phi", params["osc_start"])
)

osc_start = params.get("osc_start") or motor_positions.get("phi")

acq_parameters.osc_start = osc_start
kappa = motor_positions.get("kappa", False)
kappa = kappa if kappa else None
Expand Down
157 changes: 0 additions & 157 deletions mxcubecore/HardwareObjects/DESY/Centring.py

This file was deleted.

137 changes: 0 additions & 137 deletions mxcubecore/HardwareObjects/DESY/DigitalZoomMotor.py

This file was deleted.

2 changes: 1 addition & 1 deletion mxcubecore/HardwareObjects/DESY/MjpgStreamVideo.py
Original file line number Diff line number Diff line change
Expand Up @@ -968,7 +968,7 @@ def _do_imagePolling(self, sleep_time):
# image.setOffset(QPoint(300,300))
# self.image = QPixmap.fromImage(image)
self.image = QPixmap.fromImage(
image.scaled(self.display_width, self.display_height)
image.scaled(int(self.display_width), int(self.display_height))
)
self.emit("imageReceived", self.image)
# gevent.sleep(0.1)
Loading
Loading