P11 develop debug #859
P11 develop debug #859
Conversation
| @@ -486,3 +486,19 @@ def _update_selection(self): | |||
| s._set_loaded(False) | |||
|
|
|||
| self._set_selected_sample(None) | |||
|
|
|||
| def _set_loaded_sample(self, sample): | |||
There was a problem hiding this comment.
@agruzinov, is defining this method solves the recurrence problem you've mentioned?
There was a problem hiding this comment.
Yes, it solves the "loading failed" problem.
| osc_pars["kappa"] = 0 | ||
| osc_pars["kappa_phi"] = 0 |
There was a problem hiding this comment.
Do you have minikappa head on your diffarctometer?
There was a problem hiding this comment.
No, this is just not to have none values, just in case. Does it make sense?
There was a problem hiding this comment.
It is OK if you would never use minikappa.
|
Funny enough after synchronising with the latest develop on github webpage, linting test is failing now, although I did not change a contenent. |
…becore into p11_develop_debug
| if start_at >= stop_angle: | ||
| init_pos = start_at | ||
|
|
||
| init_pos = start_at # - self.acq_speed * self.turnback_time |
There was a problem hiding this comment.
Currently both branches of the 'if' statement are identical - and anyway init_pos is not used so both do nothing. Harmless, but maybe a clean-up or comment-out?
There was a problem hiding this comment.
Did it, thanks! It is still not clear if this is an issue or not.
| @@ -333,7 +333,7 @@ def manual_centring(self, phi_range=120, n_points=3): | |||
| self.user_clicked_event = AsyncResult() | |||
| x, y = self.user_clicked_event.get() | |||
| if click < 2: | |||
| phi_mot.set_value_relative(phi_range) | |||
| phi_mot.set_value_relative(phi_range, timeout=5) | |||
There was a problem hiding this comment.
If your phi_mot inherits from AbstractMotor, than only means that you will wait max 5s for the motor to move an will raise TimeoutError if the movement takes longer. It does not give you an extra time for the clicking.
Maybe your problem was that by default the timeout=0, meaning, do not wait for the movement to finish.
There was a problem hiding this comment.
Thanks for the comment! What would be the best way to mitigate it? I do not see any "wait" option there.
There was a problem hiding this comment.
timeout=None waits forever. But you can as well put some big value, like 2 min (timeout=60). This is only security - the command will return as soon as the movement has finished.
You may want to have a look at the AbstractMotor.py. It says:
timeout (float): optional - timeout [s], If timeout == 0: return at once and do not wait; if timeout is None: wait forever
There was a problem hiding this comment.
OK, thanks for the tip. Cheers!
| # Keep it here as it is not clear if it is needed. | ||
| # It was used in CC to fix the issue with the data processing | ||
| # h5fd["entry/sample/transformations/omega"].attrs["vector"] = [ | ||
| # 1.0, | ||
| # 0.0, | ||
| # 0.0, | ||
| # ] | ||
| # h5fd["entry/instrument/detector/module/fast_pixel_direction"].attrs[ | ||
| # "vector" | ||
| # ] = [1.0, 0.0, 0.0] | ||
| # h5fd["entry/instrument/detector/module/slow_pixel_direction"].attrs[ | ||
| # "vector" | ||
| # ] = [0.0, 1.0, 0.0] |
There was a problem hiding this comment.
This represents the direction of the diffractometer head in your metadata image. If your detector is Eiger and you use the dectris filewriter, these values are set by default as horizontal orientation, so you need to change to something else if your diffractometer is not the same.
Debug after upgrading to the latest development.