-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Beam definer #872
Beam definer #872
Changes from all commits
5183a28
520a29a
8930262
874e6a7
6567450
8eba433
02ac26a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,97 @@ | ||
# encoding: utf-8 | ||
# | ||
# Project: MXCuBE | ||
# https://github.com/mxcube | ||
# | ||
# This file is part of MXCuBE software. | ||
# | ||
# MXCuBE is free software: you can redistribute it and/or modify | ||
# it under the terms of the GNU Lesser General Public License as published by | ||
# the Free Software Foundation, either version 3 of the License, or | ||
# (at your option) any later version. | ||
# | ||
# MXCuBE is distributed in the hope that it will be useful, | ||
# but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
# GNU Lesser General Public License for more details. | ||
# | ||
# You should have received a copy of the GNU Lesser General Public License | ||
# along with MXCuBE. If not, see <http://www.gnu.org/licenses/>. | ||
|
||
""" | ||
BeamDefinerMockup class | ||
|
||
<object class="BeamDefinerMockup"> | ||
<username>beamDefiner</username> | ||
<object hwrid="/beam_size_ver" role="beam_size_ver" /> | ||
<object hwrid="/beam_size_hor" role="beam_size_hor" /> | ||
<values>{"50x50": "50x50", "100x100": "100x100", "20x5": "20x5"}</values> | ||
<styling>{"50x50":{100: "disable", 50: "default", 20: "normal", 10: "warning", 5: "warning"}, | ||
"100x100": {100: 'default',50: 'normal',20: 'normal',10: 'warning', 5: 'warning'},'20x5': {100: 'disable',50: 'disable',20: 'normal',10: 'default',5: 'normal'}, "UNKNOWN": {100: 'default',50: 'normal',20: 'normal',10: 'normal',5: 'normal'}}</styling> | ||
</object> | ||
|
||
|
||
""" | ||
|
||
from mxcubecore.BaseHardwareObjects import HardwareObject | ||
from mxcubecore.HardwareObjects.abstract.AbstractNState import AbstractNState | ||
|
||
|
||
class BeamDefinerMockup(AbstractNState): | ||
def __init__(self, *args): | ||
super().__init__(*args) | ||
self.beam_size_hor = None | ||
self.beam_size_ver = None | ||
self.custom_styling = None | ||
def init(self): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm surprised that this does not create a linting error, if not I think it looks better with a blank line between these methods |
||
AbstractNState.init(self) | ||
|
||
self.beam_size_hor = self.get_object_by_role("beam_size_hor") | ||
self.beam_size_ver = self.get_object_by_role("beam_size_ver") | ||
self.beam_size_hor.connect | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This line looks really strange. |
||
|
||
self.connect(self.beam_size_hor, "valueChanged", self.motors_changed) | ||
self.connect(self.beam_size_ver, "valueChanged", self.motors_changed) | ||
self.get_custom_styling() | ||
def motors_changed(self, value): | ||
_val = self.get_value() | ||
self.emit("valueChanged", _val) | ||
|
||
def get_custom_styling(self): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What does custom styling do ? :) |
||
try: | ||
_ap = eval(self.get_property("styling")) | ||
except: | ||
print("malformed xml") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nicer with a log :) |
||
_ap = None | ||
self.custom_styling = _ap | ||
return self.custom_styling | ||
|
||
def get_state(self): | ||
"""Get the device state. | ||
Returns: | ||
(enum 'HardwareObjectState'): Device state. | ||
""" | ||
return self.STATES.READY | ||
|
||
def get_value(self): | ||
"""Get the device value | ||
Returns: | ||
""" | ||
try: | ||
hor = int(self.beam_size_hor.get_value()) | ||
ver = int(self.beam_size_ver.get_value()) | ||
_val = f"{hor}x{ver}" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I guess you could do |
||
en = self.value_to_enum(_val) | ||
return en | ||
except ValueError: | ||
return -1 | ||
|
||
def set_value(self, val): | ||
"""Set the beam size. | ||
Args: | ||
size_x: horizontal size | ||
size_y: vertical size | ||
""" | ||
size_x, size_y = val.split("x") | ||
self.beam_size_hor._move(float(size_x)) | ||
self.beam_size_ver._move(float(size_y)) |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -38,8 +38,10 @@ def __init__(self, name): | |
|
||
self._beam_size_dict["slits"] = [9999, 9999] | ||
self._beam_size_dict["aperture"] = [9999, 9999] | ||
self._beam_size_dict["definer"] = [9999, 9999] | ||
self._beam_position_on_screen = [680, 512] | ||
self._beam_divergence = (0, 0) | ||
self.beam_size_determination = None | ||
|
||
def init(self): | ||
AbstractBeam.init(self) | ||
|
@@ -48,6 +50,7 @@ def init(self): | |
self.get_property("beam_position", "[318, 238]") | ||
) | ||
|
||
self.beam_size_determination = self.get_property("beam_size_determination") | ||
self._aperture = self.get_object_by_role("aperture") | ||
if self._aperture is not None: | ||
self.connect( | ||
|
@@ -67,6 +70,14 @@ def init(self): | |
sx, sy = self._slits.get_gaps() | ||
self._beam_size_dict["slits"] = [sx, sy] | ||
|
||
self._beam_definer = self.get_object_by_role("beam_definer") | ||
if self._beam_definer is not None: | ||
self.connect(self._beam_definer, "valueChanged", self.beam_definer_changed) | ||
|
||
_definer = self._beam_definer.get_value() | ||
sx, sy = _definer.value.split("x") | ||
self._beam_size_dict["definer"] = [float(sx), float(sy)] | ||
|
||
self.evaluate_beam_info() | ||
self.re_emit_values() | ||
self.emit("beamPosChanged", (self._beam_position_on_screen,)) | ||
|
@@ -93,6 +104,16 @@ def slits_gap_changed(self, size): | |
self.evaluate_beam_info() | ||
self.re_emit_values() | ||
|
||
def beam_definer_changed(self, definer): | ||
if definer.value != "UNKNOWN": | ||
sx, sy = definer.value.split("x") | ||
else: | ||
_aperture = self._aperture.get_diameter_size() | ||
sx, sy = [_aperture, _aperture] | ||
self._beam_size_dict["definer"] = [float(sx), float(sy)] | ||
self.evaluate_beam_info() | ||
self.re_emit_values() | ||
|
||
def set_beam_position_on_screen(self, beam_x, beam_y): | ||
""" | ||
Sets beam mark position on screen | ||
|
@@ -136,5 +157,55 @@ def get_available_size(self): | |
aperture_list = self._aperture.get_diameter_size_list() | ||
return {"type": "enum", "values": aperture_list} | ||
|
||
def get_available_definer(self): | ||
if self._beam_definer is not None: | ||
definer_list = [item.value for item in self._beam_definer.VALUES] | ||
else: | ||
return {} | ||
return {"type": "enum", "values": definer_list} | ||
|
||
def set_value(self, value): | ||
self._aperture.set_diameter_size(value) | ||
|
||
def set_beam_definer(self, value): | ||
if self._beam_definer is not None: | ||
self._beam_definer.set_value(value) | ||
|
||
def evaluate_beam_info(self): | ||
""" | ||
Method called if aperture, slits or focusing has been changed | ||
Returns: dictionary, {size_x: 0.1, size_y: 0.1, shape: BeamShape enum} | ||
""" | ||
if self.beam_size_determination is None: | ||
# we keep the minumum | ||
size_x = min( | ||
self._beam_size_dict["aperture"][0], | ||
self._beam_size_dict["slits"][0], | ||
self._beam_size_dict["definer"][0], | ||
) | ||
size_y = min( | ||
self._beam_size_dict["aperture"][1], | ||
self._beam_size_dict["slits"][1], | ||
self._beam_size_dict["definer"][1], | ||
) | ||
elif self.beam_size_determination == "definer": | ||
size_x = self._beam_size_dict["definer"][0] | ||
size_y = self._beam_size_dict["definer"][1] | ||
elif self.beam_size_determination == "slits": | ||
size_x = self._beam_size_dict["slits"][0] | ||
size_y = self._beam_size_dict["slits"][1] | ||
Comment on lines
+179
to
+196
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could we not just use the already existing beam_definer instead?? Maybe I did not quite get the logic, but if there is a definer, the evaluate_beam should take the definer size. Otherwise, if you still want to continue with your code, you should define aperture as well. |
||
|
||
self._beam_width = size_x | ||
self._beam_height = size_y | ||
|
||
if tuple(self._beam_size_dict["aperture"]) < tuple( | ||
self._beam_size_dict["slits"] | ||
): | ||
self._beam_shape = BeamShape.ELIPTICAL | ||
else: | ||
self._beam_shape = BeamShape.RECTANGULAR | ||
|
||
self._beam_info_dict["size_x"] = size_x | ||
self._beam_info_dict["size_y"] = size_y | ||
self._beam_info_dict["shape"] = self._beam_shape | ||
return self._beam_info_dict |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice with a mockup 👍