Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beam refactoring - definer and size (former Aperture as NState) #919

Merged
merged 14 commits into from
Aug 20, 2024
Merged

Beam refactoring - definer and size (former Aperture as NState) #919

merged 14 commits into from
Aug 20, 2024

Conversation

beteva
Copy link
Member

@beteva beteva commented Apr 17, 2024 •
edited
Loading

Inherit from AbstractNState.
Using the new beam definer #872 from @meguiraun

@beteva beteva marked this pull request as draft April 17, 2024 16:29
@beteva
Copy link
Member Author

beteva commented Jul 4, 2024

@meguiraun I've started using your beam_definer branch. For time being this is only aperture and slits, Please, have a look.
The definer will follow soon.

@beteva beteva requested a review from meguiraun July 5, 2024 08:02
@beteva beteva changed the title [WIP] Aperture as NState Aperture as NState Jul 5, 2024
@beteva beteva marked this pull request as ready for review July 5, 2024 08:04
@marcus-oscarsson
Copy link
Member

@beteva, @meguiraun Nice :). @meguiraun you can go ahead and merge this if you are happy with it. It would probably be nice with some additional documentation for AbstractBeam as its quite complext, or do you think that this is enough:
https://mxcubecore.readthedocs.io/en/stable/dev/abstract_classes.html#abstractbeam ?

@beteva beteva changed the title Aperture as NState Beam refactoring - definer and size (former Aperture as NState) Jul 18, 2024
@beteva
Copy link
Member Author

beteva commented Jul 18, 2024

The definer part (based on @meguiraun beam_definer branch) has been added. Some methods to handle the beam size have been added.

@marcus-oscarsson
Copy link
Member

@beteva and @meguiraun are you happy with this as it is ?

@meguiraun
Copy link
Contributor

I am happy with this. I still need to adapt to our custom hwobj but I believe it is a solid foundation.

@beteva beteva merged commit f0faff7 into develop Aug 20, 2024
11 checks passed
@beteva beteva deleted the nstate_aperture branch August 20, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meguiraun meguiraun meguiraun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@beteva @marcus-oscarsson @meguiraun