MAXIV: update Machine Info HWO #974
Conversation
|
Not sure, this implementation is based on old version of MachineInfo HWO from BioMAX. I did not knew that TangoMachineInfo existed. I'll take a look if we can use that instead. |
|
I have looked at TangoMachineInfo now. The TangoMachineInfo is designed to read all machine info topics from one specified tango device. Here at MAXIV the topics are provided by multiple tango devices. We also need to do some parsing for a topic, thus we'll need to have a custom MachineInfo HWO anyway. I feel that trying to use TangoMachineInfo in our case will make the implementation more complicated compared to how it's done in this PR. |
| values['lifetime'] | ||
| values['topup_remaining'] | ||
| """ | ||
| def catch_errs(func): |
There was a problem hiding this comment.
:), I would have simply called it catch_errors but its matter of taste I guess and it is after all site specific code
There was a problem hiding this comment.
good point, I have changed it to catch_errors
| MachInfo hardware objects are used to obtain information from the accelerator | ||
| control system. | ||
| # how often we refresh machine info | ||
| REFRESH_PERIOD_SEC = 30 |
There was a problem hiding this comment.
You could also easily make it configurable via get_property but perhaps not desired in your case.
There was a problem hiding this comment.
I feel it's not worth the hassle in this case. We have not changed this value on a very long time.
|
Looks good to me, Ill let you rebase and merge :), you (of-course) do as you like with the comments |
New MachInfo hardware object, for using at BioMAX and MicroMAX. Based on older HWO used at BioMAX, but updated to follow the new AbstractMachineInfo API.
I have re-based, but I don't have the commit bit to do the merge. 😞 |
|
Oh, I think it should be ok now :) |
Updated MachInfo hardware object, for use at MAXIV BioMAX and MicroMAX beamlines.
Based on older BioMAX HWO, updated to follow the new AbstractMachineInfo API and refactored.