Improved yaml linting and tightened config. Set YAML 1.2 everywhere #1288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabcor-maxiv
reviewed
Jul 5, 2024
poetry.lock
Outdated
There was a problem hiding this comment.
This file (poetry.lock) should not have changed. I do not understand where this change comes from.
Maybe you could restore the file to its previous state and re-run poetry install or something like this.
|
Same comment as for this PR: mxcube/mxcubecore#957 Let's merge this into |
…uredObject now cleaned
|
@rhfogh Did you notice that there is a conflict ? |
# Conflicts: # test/HardwareObjectsMockup.xml/gphl/gphl-workflow.yml
|
@marcus-oscarsson The conflict should be fixed now. Thanks for pointing it out. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion pull request to mxcubecore PR #957
There may be problems with poetry.lock and/or with mxcubeweb PR #1285.