-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to latest react-boilerplate #28
Comments
I totally agree, we need to update this to v3. Feel free to submit a PR! |
Grüß Gott @mxstbr, I would be happy to PR for you because I need a form login and as far as I know, I will do it on v3. I have not so much experience with react but I read a lot about it and I know all the other js client library so it might take a while. That's why I choose to go straight to your project because you seems to have good answers to problem and some experience in the React world. Since I am new to react boilerplate, It would be nice if you could provide me some form example with xhr request in v3, to see how it goes with redux-saga and adapt it. There is no such case in the sample project in v3. |
I have tried to implement it in v3 but I still got a bit confuse how to write the sagas. I have no PageHome so I just do the following : in
in
in
I encounter the following problems :
What is not very clear for me now is how you get the field from the form the html form.
in
I know the implementation is incomplet , and my browser log me this :
it's a pain to debug as I can't use my usual browser debugger to see where does this error come from in my code. So here is a basic question, the form is just an example action, should I keep the form attributes in the root state ? |
Hi again @mxstbr, @gihrig I keep encountering trouble converting the followings files :
redux-saga was not in the login-flow project, so I have to make my own sagas. I have a good working sagas example here for fetching repos from github :
And of course, I did the redux-saga tutorial. However, I can't reproduce a working Should the sagas fonction be a plain object or a function ? Edit: In case someone accept to have a quick look here is the code merged with the sagas borrowed from https://github.com/sotojuan/saga-login-flow :
|
Feel free to submit a WIP PR, it's a bit hard to judge just by your description! |
@mxstbr, I found this project: https://github.com/sotojuan/saga-login-flow/issues/25 |
Wait sorry, why is it entirely different? |
Hey, was just posting about the issues I'm having and read this... I need to get this working as well, I'm implementing the React-Boilerplate with Login-Flow, but using the work of sotojuan as well, to implement the saga things... although it's not quite there yet. Having a few issues. |
For anybody else who lands here - I upgraded login-flow to v3.4 (with the help of saga-login-flow) and added json-server integration. It's a WIP and I'm evolving it as I go, but you can find the code on github: https://github.com/tinavanschelt/recycled-login-flow and the app here: http://recycled-login-flow.herokuapp.com/ Cheers. |
Hi, I have downloaded both react boiler plate and this application.
I can't recognize the boilerplate in login-flow, is this code compatible with the new app folder design / boot ?
Perhaps it is not so long to upgrade this project to demonstrate the integration using react-boilerplate OR add this example directly in the sample project of react boilerplate (before the clean)
The text was updated successfully, but these errors were encountered: