Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrating Redux Auth Wrapper #615

Closed
wullaski opened this issue Jun 30, 2016 · 6 comments
Closed

Integrating Redux Auth Wrapper #615

wullaski opened this issue Jun 30, 2016 · 6 comments
Labels

Comments

@wullaski
Copy link

I have a basic login flow working but I've hit a wall with integrating a routing solution to check authentication and redirect based on user status. I wanted to be able to use Redux Auth Wrapper but the way the routes are generated makes integration difficult/less clear. Is there an easy solution for this?

@mxstbr
Copy link
Member

mxstbr commented Jun 30, 2016

Have never worked with redux-auth-wrapper before, but https://github.com/sotojuan/saga-login-flow by @sotojuan is solid! onEnter: checkAuth works perfectly fine as far as I know.

@sotojuan
Copy link
Contributor

Yep, onEnter just works. Not sure if it's the cleanest solution but it gets the job done :-)

@mxstbr mxstbr closed this as completed Jun 30, 2016
@oyeanuj
Copy link

oyeanuj commented Aug 6, 2016

On onEnter vs HoC, this might be relevant: http://stackoverflow.com/a/34932997

@ansumanshah
Copy link
Contributor

@oyeanuj have you tried integrating redux-auth-wrapper can you provide an example/gist please?

@mjrussell
Copy link

For those looking for advice on how to integrate with redux-auth-wrapper, this is a good starting place: mjrussell/redux-auth-wrapper#40 (comment)

As @oyeanuj linked, there are a couple of edge cases onEnter didn't solve in my application which is what prompted me to write the HOC library.

@lock
Copy link

lock bot commented May 30, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators May 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

6 participants