Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for .js by default #158 #160

Merged
merged 2 commits into from
Feb 20, 2018
Merged

Allow for .js by default #158 #160

merged 2 commits into from
Feb 20, 2018

Conversation

rafaelkallis
Copy link
Contributor

Discussion in #158

g:jsx_ext_required = 0 is set by default.

@trevordmiller
Copy link

@rafaelkallis Looks great to me other than the documentation should also be updated here in your PR:
https://github.com/mxw/vim-jsx/blob/master/README.md#usage

@mxw
Copy link
Owner

mxw commented Feb 19, 2018

Can you undo all the spurious changes to README?

@rafaelkallis
Copy link
Contributor Author

@mxw done!

@trevordmiller
Copy link

Looking forward to this one :)

@mxw mxw merged commit 52ee8bb into mxw:master Feb 20, 2018
@mxw
Copy link
Owner

mxw commented Feb 20, 2018

Thanks, folks! I didn't realize this had become so much the usual convention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants