Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight comments inside XML tags #164

Merged
merged 1 commit into from
Aug 1, 2018
Merged

Highlight comments inside XML tags #164

merged 1 commit into from
Aug 1, 2018

Conversation

jiulongw
Copy link
Contributor

@jiulongw jiulongw commented Mar 21, 2018

Comments inside react tags are not colored as comments. This PR fixes this.

return (
  <MyComponent
    // this is a comment
    style={...}
  />
);

@mxstbr
Copy link

mxstbr commented Jun 12, 2018

Can confirm that this PR works. Before:

screen shot 2018-06-12 at 11 38 47

After:

screen shot 2018-06-12 at 11 40 18

@mxw mxw merged commit b96fdc5 into mxw:master Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants