Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow more flexible environment settings #146

Merged
merged 4 commits into from
Aug 20, 2019
Merged

Allow more flexible environment settings #146

merged 4 commits into from
Aug 20, 2019

Conversation

harawata
Copy link
Member

  1. Migrations can read environment settings from environment variables or system properties.
  2. In the properties file, variable expressions ${} are replaced if there is a matching system property or environment variable.

Regarding 1 ...

  • Settings are read in the following order of priority (high to low)
    1. System property
    2. Environment variable
    3. Properties file
  • System property and environment variable must be declared under the name with prefix (e.g. MIGRATIONS_USERNAME, MIGRATIONS_PASSWORD).

Should close #114 and replace #128 and #144 .

@harawata
Read environment settings from system properties or environment varia…
224aac4 
…bles

Testing only system properties.
If I found a good way to prepare environment variables, I'll add it later.
@harawata
Replace variable expression ${} in environment properties file
cd8a4d8
@harawata harawata requested a review from h3adache July 13, 2019 16:44
@harawata
Read user defined variables from environment variables and system pro…
69c6b9a 
…perties

Variables must be declared with a name with prefix (e.g. `MIGRATIONS_VAR1`).
The name is converted to lower case (e.g. `MIGRATIONS_VAR1` -> `var1`).
@harawata
Add a test for environment variables.
bf593c4
@h3adache h3adache merged commit ac708a7 into mybatis:master Aug 20, 2019
@harawata harawata modified the milestone: 3.3.6 Aug 20, 2019
harawata added a commit that referenced this pull request Aug 20, 2019
@harawata
Added a brief explanation about #146
f12d245
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h3adache h3adache h3adache requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow environment configuration override via Java System Properties or Environment Variables
2 participants
@harawata @h3adache