-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow referencing result map from @One and @Many #1771
Allow referencing result map from @One and @Many #1771
Conversation
Thank you for the, @moonService ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR, @moonService !
I added a few change requests.
Let me know if you have any question.
src/test/java/org/apache/ibatis/submitted/annotion_many_one_add_resultmapid/CreateDB.sql
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/ibatis/builder/annotation/MapperAnnotationBuilder.java
Show resolved
Hide resolved
src/test/java/org/apache/ibatis/submitted/annotion_many_one_add_resultmapid/UserDao.java
Outdated
Show resolved
Hide resolved
@harawata At your request,I modified some places,please check them If you have time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just noticed that there are two files copyrighted by your organization. Please see the comments.
src/test/java/org/apache/ibatis/submitted/annotion_many_one_add_resultmapid/UserDao.java
Show resolved
Hide resolved
src/test/java/org/apache/ibatis/submitted/annotion_many_one_add_resultmapid/RoleDao.java
Show resolved
Hide resolved
d519d24
to
dd8d87e
Compare
Thank you, @moonService for the update! Just to be safe, let me merge this after the 3.5.4 release. |
@harawata ok |
@One
and @Many
@One
and @Many
It's merged. Thank you again, @moonService ! I plan to add |
Thank you, @moonService ! |
@many and @one add resultMapId