Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant call to Reflector#getClassMethods() #2335

Merged
merged 3 commits into from
Sep 7, 2021
Merged

Remove redundant call to Reflector#getClassMethods() #2335

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
60ee625
Add an attribute 'allMethods' to cache all methods,reduce repetitive …
mbond-cloud Sep 2, 2021
e2d32a9
Modify constructor ,add local variable 'allMethods' (Method[]),change…
mbond-cloud Sep 6, 2021
bd26999
Cosmetic changes
harawata Sep 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions src/main/java/org/apache/ibatis/reflection/Reflector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,9 @@ public class Reflector {
public Reflector(Class<?> clazz) {
type = clazz;
addDefaultConstructor(clazz);
addGetMethods(clazz);
addSetMethods(clazz);
Method[] classMethods = getClassMethods(clazz);
addGetMethods(classMethods);
addSetMethods(classMethods);
addFields(clazz);
readablePropertyNames = getMethods.keySet().toArray(new String[0]);
writablePropertyNames = setMethods.keySet().toArray(new String[0]);
Expand All @@ -83,9 +84,8 @@ private void addDefaultConstructor(Class<?> clazz) {
.findAny().ifPresent(constructor -> this.defaultConstructor = constructor);
}

private void addGetMethods(Class<?> clazz) {
private void addGetMethods(Method[] methods) {
Map<String, List<Method>> conflictingGetters = new HashMap<>();
Method[] methods = getClassMethods(clazz);
Arrays.stream(methods).filter(m -> m.getParameterTypes().length == 0 && PropertyNamer.isGetter(m.getName()))
.forEach(m -> addMethodConflict(conflictingGetters, PropertyNamer.methodToProperty(m.getName()), m));
resolveGetterConflicts(conflictingGetters);
Expand Down Expand Up @@ -134,9 +134,8 @@ private void addGetMethod(String name, Method method, boolean isAmbiguous) {
getTypes.put(name, typeToClass(returnType));
}

private void addSetMethods(Class<?> clazz) {
private void addSetMethods(Method[] methods) {
Map<String, List<Method>> conflictingSetters = new HashMap<>();
Method[] methods = getClassMethods(clazz);
Arrays.stream(methods).filter(m -> m.getParameterTypes().length == 1 && PropertyNamer.isSetter(m.getName()))
.forEach(m -> addMethodConflict(conflictingSetters, PropertyNamer.methodToProperty(m.getName()), m));
resolveSetterConflicts(conflictingSetters);
Expand Down