Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding mapper could fail under JPMS #2731

Merged
merged 1 commit into from
Nov 12, 2022
Merged

Adding mapper could fail under JPMS #2731

merged 1 commit into from
Nov 12, 2022

Conversation

harawata
Copy link
Member

Under JPMS (Java Platform Module System), ClassLoader#getResources() could throw FileSystemException it seems.

Should fix #2598

@harawata
Adding mapper could fail under JPMS
ced7973 
Under JPMS, ClassLoader#getResources() throws `FileSystemException` it seems.
It might be better to catch IOException, but it could swallow some exception that should be thrown.

Should fix mybatis#2598
@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.309% when pulling ced7973 on harawata:jpms-file-system-exception into afc439a on mybatis:master.

@harawata harawata merged commit 2e208e6 into mybatis:master Nov 12, 2022
@harawata harawata self-assigned this Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@harawata harawata

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Running java9 module project, addMappers() could throw FileSystemException
2 participants
@harawata @coveralls