[ci] Cleanup charset usage #2752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok seems a bug in the modernizer, will remove the one and try the other. |
hazendaz
force-pushed
the
master
branch
2 times, most recently
from
b6b09d5
to
67cb10d
Compare
|
This one works as tests are set to 11. possibly this is causing a bug in modernizer as it fails now at 37 if we don't update the source side which we cannot yet. For now, taking what we can from that and will continue to review that before parent is released. |
|
no bug in modernizer, issue is due to mybatis becoming jdk 16 when ran with defaults and proper jdk involved. In that scenario it will want to fix the code which I now recall. Same was true with what I patched here but after last parent we now allow jdk 11 with tests so that one is now ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
few modernization issues detected with parent 37 snapshot.