-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests] Rework test process and document it dropping use of prioer profile for straight property usage #2820
Conversation
@harawata I had made this change in the parent some time ago. Had this sitting around and not pushed so switching over. Odd behavior though is that before this had 1765 ubuntu tests run at jdk 11. Now it is 1730. I added a few extra helpers now so we know what profiles are active. Everything looks right. All other tests run expected numbers. The active profiles are correct. Would you happen to have any idea what might be the issue? Presumably 'excludedGroups' is acting different. Here is profile from the parent
In the parent it defines excludedGroups as
I suspect a resolution different due to parent controlling now. And maybe our GH actions for CI is just wrongly setup. The default exclusion in mybatis-3 is TestcontainersTests. |
… set excludedGroups profile is not needed. All we are doing is setting a property.
trying to not have profile at all as it seems unnecessary based on how all the other setup is working... |
@harawata ok resolved another way here. Got rid of using the profile all together. That seems to do the trick. |
…readable