XNode#toString() should output all child nodes #3001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Keeping indentation, but it won't be perfect in multi-line text nodes. - Add a new line after each open/close tag even for a short line like `<id>3</id>`. There aren't many short lines like that in MyBatis mappers. - Use 2 spaces for indentation instead of 4 to save earth. Should fix mybatis#2080 Should close mybatis#2084 mybatis#2552 mybatis#2998
human-user
reviewed
Nov 8, 2023
This was referenced Nov 10, 2023
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
toString()and not a coder formatter program, simplicity has precedence over perfect formatting.<id>3</id>. It should not bother you much because there aren't many short lines like that in MyBatis mappers.Should fix #2080
Should close #2084 #2552 #2998 as obsolete