Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore .vm usage lost in .xdoc to .md migration #759

Closed
wants to merge 1 commit into from

Conversation

hboutemy
Copy link
Contributor

this fixes Reproducible Builds issue detected in recent releases: https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/org/mybatis/mybatis-spring/mybatis-spring-3.0.0.diffoscope

as you can see:

  • user directory is currently stored in .jar file
  • site content is stored in -sources.jar in user directory

this was caused by the migration from .xdoc to .md in 322a051 where the .xdoc.vm was changed to .md with a tweak on resources filtering because of a "classical" conflict on ##between Velocity and Markdown https://maven.apache.org/plugins/maven-site-plugin/examples/creating-content.html#common-issues-and-workarounds

this fixes Reproducible Builds issue
@coveralls
Copy link

coveralls commented Nov 27, 2022

Coverage Status

Coverage remained the same at 89.456% when pulling 1ce16d0 on hboutemy:velocity-markdown into 9b1f5a1 on mybatis:master.

@kazuki43zoo
Copy link
Member

@hboutemy Thanks you for your reporting!!

I found a solution for fixing this problem, it is maven.source.excludeResources=true as maven properties.
I prefer to use .md file instead of .vm file cannot render on GitHub UI.

@hboutemy
Copy link
Contributor Author

I prefer to use .md file instead of .vm file cannot render on GitHub UI.

I see, thanks for sharing

it is maven.source.excludeResources=true as maven properties

this one means you will not copy the .md resources but also not any other: your are abusing the main resources definition in pom.xml.

I think the best way would be to configure an execution of resource:copy-resources with your specific resources: https://maven.apache.org/plugins/maven-resources-plugin/usage.html

hboutemy added a commit to hboutemy/spring that referenced this pull request Dec 3, 2022
@hboutemy
Copy link
Contributor Author

hboutemy commented Dec 3, 2022

@kazuki43zoo I proposed #763 PR as an implementation of the use of maven-resources-plugin that I proposed

@hazendaz hazendaz closed this in #763 Dec 5, 2022
kazuki43zoo pushed a commit to kazuki43zoo/spring that referenced this pull request Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants