Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build, Add support for doctrine/common:v3 #172

Merged
merged 4 commits into from
Mar 2, 2022

Conversation

Slamdunk
Copy link
Contributor

  • Raise minimum required version to pass --prefer-lowest build
  • Add support for doctrine/common:v3
  • Add CI badge

@Slamdunk Slamdunk changed the title Fix build, support doctrine/common:v3 Fix build, Add support for doctrine/common:v3 Feb 18, 2022
@@ -3,7 +3,7 @@
namespace DeepCopy\Matcher\Doctrine;

use DeepCopy\Matcher\Matcher;
use Doctrine\Common\Persistence\Proxy;
use Doctrine\Persistence\Proxy;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doctrine already published a forward compatibility alias, so we don't need to care about it:
https://github.com/doctrine/persistence/blob/1.3.8/lib/Doctrine/Common/Persistence/Proxy.php

@mnapoli
Copy link
Member

mnapoli commented Mar 2, 2022

Awesome thank you!

@mnapoli mnapoli merged commit c6a951b into myclabs:1.x Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants