Fix for Exception #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We cannot assume that EVERY object we receive here implements the getName method. Therefore we should fall back to the ReflectionObject which implements the method (via ReflectionClass).
|
Good point! 👍 |
|
Oh good catch! That was probably a typo, could you please fix the test (https://travis-ci.org/myclabs/DeepCopy/jobs/90081673) so that the build is green? |
|
Kind of busy right now, but I can have a look into it over the next few days. |
|
I will fix this, looks like a one-line fix. |
|
Opened PR for this PR. :-) |
|
👍 that's meta, will merge once it's merged ;) |
Fixed wrong reference in Exception message
|
Sorry for the delay :) |
|
If you want to get rid of merge commit just do rebase. (but it is not technicaly neccesary) |
|
Perfectly fine like this! Thanks both! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cannot assume that EVERY object we receive here implements the getName method. Therefore we should fall back to the ReflectionObject which implements the method (via ReflectionClass).