Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve uncloneable exception #7

Merged
merged 2 commits into from
Nov 20, 2014
Merged

Improve uncloneable exception #7

merged 2 commits into from
Nov 20, 2014

Conversation

jjsaunier
Copy link
Contributor

hey,

I just improve uncloneable exception, when you don't want to skip uncloneable and you got exception from php clone you got this message:

Error: Trying to clone an uncloneable object of class ReflectionClass in /home/.../vendor/myclabs/deep-copy/src/DeepCopy/DeepCopy.php line 132

Now:

Class "Acme\AcmeDemoBundle\Entity\Acme" is not cloneable.

This throw DeepCopy\Exception\CloneException

Now it is easy to see which class raises concerns directly :)

@mnapoli
Copy link
Member

mnapoli commented Nov 20, 2014

Good stuff! thanks

mnapoli added a commit that referenced this pull request Nov 20, 2014
@mnapoli
Merge pull request #7 from ProPheT777/improvement-1
d93c485 
Improve uncloneable exception
@mnapoli mnapoli merged commit d93c485 into myclabs:master Nov 20, 2014
@mnapoli
Copy link
Member

mnapoli commented Nov 20, 2014

I've released 1.2.1

@mnapoli mnapoli added the bug label Mar 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjsaunier @mnapoli