Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: merge travis matrix, add salt-lint & rubocop to lint job #60

Merged
merged 13 commits into from
Oct 10, 2019

Commits on Oct 8, 2019

  1. refactor(defaults): use node anchors for common line_length values

    * To be reused for upcoming `rubocop` settings as well
    myii committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    ac9b7a5 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2019

  1. Configuration menu
    Copy the full SHA
    dbee3f7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8d86eb4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1d9636e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f4fc3c1 View commit details
    Browse the repository at this point in the history
  5. fix(gemfile): fix rubocop errors

    myii committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    e0ec88a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    58881a7 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    212edf0 View commit details
    Browse the repository at this point in the history
  8. feat(travis): use conditional to provide one or two lint jobs

    * Main goal:   one lint job
    * Alternative: split `rubocop` into a separate lint job (`allow_failures`)
    * Long-term:   to be able to fully revert this commit when a single lint
                   job can be use for all formulas
    myii committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    5c2f134 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    9ec9b1e View commit details
    Browse the repository at this point in the history
  10. feat(ufw): add specific pip3 customisations to .travis.yml

    * `ufw` is still stuck on `trusty` on Travis
      - This doesn't work with when `salt` is installed during the
        `salt-lint` installation process (issue with `tornado`)
      - Installing via. Python 3 works, albeit much slower
    myii committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    c3acbd1 View commit details
    Browse the repository at this point in the history
  11. ci: merge travis matrix, add salt-lint & rubocop to lint job

    * Automated using #60
    myii committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    2dac9b0 View commit details
    Browse the repository at this point in the history
  12. fix(salt-lint): fix errors

    ```bash
    Examining ssf/libcimatrix.jinja of type state
    [204] Lines should be no longer that 160 chars
    ssf/libcimatrix.jinja:4
    {%- macro format_ci_matrix(platforms, inspec_suites_kitchen, inspec_suites_matrix, platforms_matrix, platforms_matrix_commented_includes, semrel_formula, width=4, use_new_travis_format=False ) %}
    
    [203] Most files should not contain tabs
    ssf/libcimatrix.jinja:28
    {#-             | #     | inc   | exc   | result |                                                          #}
    
    [203] Most files should not contain tabs
    ssf/libcimatrix.jinja:30
    {#-             | 1     |  y    | []    |  TRUE  |                                                          #}
    
    [203] Most files should not contain tabs
    ssf/libcimatrix.jinja:31
    {#-             | 2     |  y    |  n    |  TRUE  |                                                          #}
    
    [203] Most files should not contain tabs
    ssf/libcimatrix.jinja:32
    {#-             | 3     |  y    |  y    |  TRUE  |                                                          #}
    
    [203] Most files should not contain tabs
    ssf/libcimatrix.jinja:33
    {#-             | 4     | []    | []    |  TRUE  |                                                          #}
    
    [203] Most files should not contain tabs
    ssf/libcimatrix.jinja:34
    {#-             | 5     | []    |  n    |  TRUE  |                                                          #}
    
    [203] Most files should not contain tabs
    ssf/libcimatrix.jinja:35
    {#-             | 6     | []    |  y    | FALSE  |                                                          #}
    
    [203] Most files should not contain tabs
    ssf/libcimatrix.jinja:36
    {#-             | 7     |  n    | []    | FALSE  |                                                          #}
    
    [203] Most files should not contain tabs
    ssf/libcimatrix.jinja:37
    {#-             | 8     |  n    |  n    | FALSE  |                                                          #}
    
    [203] Most files should not contain tabs
    ssf/libcimatrix.jinja:38
    {#-             | 9     |  n    |  y    | FALSE  |                                                          #}
    
    [206] Jinja variables should have spaces before and after: {{ var_name }}
    ssf/libcimatrix.jinja:70
    {{ comment }}- {{instance_and_env }}{{ instance }}
    
    ...
    
    Examining ssf/map.jinja of type state
    [209] Jinja comment should have spaces before and after: {# comment #}
    ssf/map.jinja:10
    {## Merge the formulas ##}
    ```
    myii committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    5890b8a View commit details
    Browse the repository at this point in the history